Skip to content

Fix cross-platform path separator failures in config tests; remove demo GIFs#1

Draft
Copilot wants to merge 2 commits into
masterfrom
copilot/fix-failing-tests-remove-gifs
Draft

Fix cross-platform path separator failures in config tests; remove demo GIFs#1
Copilot wants to merge 2 commits into
masterfrom
copilot/fix-failing-tests-remove-gifs

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 10, 2026

Two config_spec.lua tests hardcoded Windows backslash paths, causing failures on Linux CI where package.config:sub(1,1) returns /. The demo GIFs in docs/ were also flagged for removal.

Changes

Test fix — spec/config_spec.lua

  • Replaced hardcoded C:\Code\MyProj\... expected values with dynamically-computed paths using package.config:sub(1,1) as the separator
  • Root path adapts per-platform: /home/user/MyProj on Linux/Mac, C:\Code\MyProj on Windows
-- before
assert.equals("C:\\Code\\MyProj\\.SageFs\\config.fsx", config.config_path("C:\\Code\\MyProj"))

-- after
local sep = package.config:sub(1, 1)
local root = sep == "\\" and "C:\\Code\\MyProj" or "/home/user/MyProj"
assert.equals(root .. sep .. ".SageFs" .. sep .. "config.fsx", config.config_path(root))

Demo GIF removal

  • Deleted docs/demo-eval-loop.gif, docs/demo-live-testing.gif, docs/demo-coverage.gif
  • Removed the three ![...] image embeds from README.md; section headings and descriptions are retained

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • luarocks.org
    • Triggering command: /usr/bin/lua5.1 /usr/bin/lua5.1 /usr/bin/luarocks install busted (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Fix failing tests and get rid of the demo gifs, they are not good.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: WillEhrendreich <55286472+WillEhrendreich@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing tests and remove demo gifs Fix cross-platform path separator failures in config tests; remove demo GIFs Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants