Rework the color picker dialog - #21
Open
matteomekhail wants to merge 30 commits into
Open
Conversation
…ue-12-divide-plugin-settings # Conflicts: # composeApp/src/commonMain/kotlin/org/wip/plugintoolkit/features/plugin/ui/PluginSettingsContent.kt
…e-12-divide-plugin-settings
…ue-12-divide-plugin-settings # Conflicts: # composeApp/src/commonMain/kotlin/org/wip/plugintoolkit/features/plugin/logic/PluginLifecycleManager.kt
…e-12-divide-plugin-settings
…-13-color-picker-rework
…ustom-setting-defaults
…e-12-divide-plugin-settings
…-13-color-picker-rework
…icker-rework # Conflicts: # composeApp/src/commonMain/composeResources/values/strings.xml
Owner
|
Most of the color picker's features were removed in this pull request. While the rework was meant to clean up and declutter the GUI by adding settings to toggle features on and off, completely removing them makes the tool less useful. This is especially true since forcing hexadecimal input makes it harder to use different color formats. Additionally, when changing the color via the hexadecimal field, the selector on the board doesn't update, which is bad UX. The color picker's settings could live in the System tab or a separate Customization tab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test
GRADLE_USER_HOME=/private/tmp/orlando-gradle bash gradlew :composeApp:jvmTest --tests org.wip.plugintoolkit.features.colorpicker.utils.ColorExtTestCloses #13