Add bridge-based profession recipe crafting UI - #15
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f42497494
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if MultiBot.Comm and MultiBot.Comm.RunProfessionRecipeCraft then | ||
| local token = MultiBot.Comm.RunProfessionRecipeCraft(frame.botName, skillId, spellId, itemId) | ||
| if token then | ||
| frame.pendingCrafts[getRecipePendingKey(frame.botName, skillId, spellId)] = true |
There was a problem hiding this comment.
Setting frame.pendingCrafts[...] = true here relies on receiving OnBridgeProfessionRecipeCraftResult to clear the flag, but there is no fallback clear on disconnect/reconnect or when a fresh recipe list arrives. If the bridge drops the PROFESSION_RECIPE_CRAFT reply (e.g., transient disconnect after sending the RUN command), this recipe stays permanently marked pending and render() keeps the Craft button disabled (...) for that bot/skill/spell until UI reload.
Useful? React with 👍 / 👎.
1 participant
No description provided.