Skip to content

Update MultiBotEvery.lua - #46

Open
kogorash wants to merge 1 commit into
Wishmaster117:mainfrom
kogorash:patch-1
Open

Update MultiBotEvery.lua#46
kogorash wants to merge 1 commit into
Wishmaster117:mainfrom
kogorash:patch-1

Conversation

@kogorash

@kogorash kogorash commented Aug 2, 2026

Copy link
Copy Markdown

nil value error fix

Summary by CodeRabbit

  • Bug Fixes
    • Improved Spellbook toggle stability when active units are missing associated buttons or frames.
    • Prevented errors while disabling Spellbook controls for incomplete unit entries.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ec97239f-4148-441e-8a41-cc448b3955cb

📥 Commits

Reviewing files that changed from the base of the PR and between df3402f and a8dd2c1.

📒 Files selected for processing (1)
  • Core/MultiBotEvery.lua

📝 Walkthrough

Walkthrough

The Spellbook toggle now checks for a unit button and frame before disabling active units. It continues to exclude the player’s unit. The surrounding strategy-button closure remains unchanged.

Changes

Spellbook control handling

Layer / File(s) Summary
Guard active unit controls
Core/MultiBotEvery.lua
The toggle skips active entries without a unit button or frame. The player-unit exclusion and function closure remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: wishmaster117

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title identifies the changed file but does not describe the nil error fix or Spellbook control change. Use a specific title such as "Fix nil access in MultiBotEvery Spellbook toggle".
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant