Add bridge-first formation controls and localized status tooltip - #47
Conversation
Moves formation selection and inspection out of PARTY/RAID chat, adds a localized per-bot formation tooltip, and keeps the scope raid-wide for all controllable bots.
|
Warning Review limit reached
Next review available in: 17 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
📝 WalkthroughWalkthroughThe PR adds asynchronous formation commands and formation queries. It processes acknowledgements, payloads, timeouts, and state resets. The UI displays localized formation results. README and roadmap documentation describe the bridge behavior. ChangesFormation support
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant FormationUI
participant MultiBotComm
participant Bridge
participant Bots
FormationUI->>MultiBotComm: RunFormationCommand(scope, target, formation, callback)
MultiBotComm->>Bridge: Send RUN~FORMATION
Bridge->>Bots: Apply formation
Bots-->>Bridge: FORMATION_ACK
Bridge-->>MultiBotComm: Return formation result
MultiBotComm-->>FormationUI: Invoke callback
FormationUI->>MultiBotComm: RequestFormations(callback)
MultiBotComm->>Bridge: Request formation data
Bridge-->>MultiBotComm: Send formation payloads
MultiBotComm-->>FormationUI: Display sorted results
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d7fdbd058
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (1)
UI/MultiBotFormationUI.lua (1)
163-186: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winFormation selection gives no feedback when the command is not sent.
MultiBot.Comm.RunFormationCommandreturnsfalsewhen the bridge is disconnected or the send fails. In that casetokenis falsy, the code skips the assignment, and the user sees nothing. The right-click path at lines 206-227 shows theformation.query.unavailabletooltip for the same condition. Align the left-click path, and also clear the stalelatestFormationToken.♻️ Proposed alignment with the right-click path
if token then latestFormationToken = token + else + latestFormationToken = nil + showFormationTooltip(button, { status = "unavailable" }) end🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@UI/MultiBotFormationUI.lua` around lines 163 - 186, Update the left-click formation command flow around RunFormationCommand to handle a falsy token like the right-click path: clear latestFormationToken and show the formation.query.unavailable tooltip when the command is not sent. Preserve the existing token assignment and callback behavior for successful sends.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Core/MultiBotComm.lua`:
- Around line 432-446: Add timeout cleanup to Comm.RunFormationCommand matching
Comm.RequestFormations: remove the pending formationCommands entry and invoke
its callback with a timeout result when no acknowledgement arrives. Also reset
state.formationCommands in Core/MultiBotComm.lua lines 1090-1090 within
Comm.MarkDisconnected, alongside the existing outfitCommands and trainerCommands
resets.
In `@docs/ROADMAP.md`:
- Around line 66-71: The documentation incorrectly describes right-click
formation inspection as PARTY/RAID-chat-based instead of bridge-delivered.
Update docs/ROADMAP.md lines 66-71 and 160-161 to state that
MultiBotFormationUI.lua uses Comm.RequestFormations() with the
GET~FORMATIONS~GROUP bridge path; docs/ROADMAP.md lines 160-161 require the same
correction. Use README.md lines 206-209 and 492-493 as the existing reference
and make no direct changes there.
In `@Locales/MultiBotAceLocale-enUS.lua`:
- Around line 1033-1049: Add the missing formation.confirm.none and
formation.confirm.partial localization keys to the English locale and every
other locale file, matching the fallback strings used by Core/MultiBotComm.lua.
Keep the keys grouped with the existing formation query/name entries so
confirmation notifications use translated locale values.
In `@Locales/MultiBotAceLocale-koKR.lua`:
- Line 1024: Update the localized string for formation.query.unavailable to
replace the English “Bridge” with the existing Korean term “브릿지,” preserving the
rest of the message unchanged.
In `@Locales/MultiBotAceLocale-ruRU.lua`:
- Line 1040: Update the `formation.name.near` localization to use the existing
noun phrase `Скученное построение` instead of `Рядом`, matching the established
formation label.
In `@README.md`:
- Around line 103-111: README.md lines 103-111, 575-591, and docs/ROADMAP.md
lines 49-61 must present one consistent bridge-request contract. Update the
request list near GET~FORMATIONS and RUN~FORMATION to document complete syntax,
including GET~FORMATIONS~GROUP~~<token> and RUN~FORMATION~GROUP, or explicitly
identify GET/RUN as request families with those full examples; keep the README
query and roadmap scope aligned.
---
Nitpick comments:
In `@UI/MultiBotFormationUI.lua`:
- Around line 163-186: Update the left-click formation command flow around
RunFormationCommand to handle a falsy token like the right-click path: clear
latestFormationToken and show the formation.query.unavailable tooltip when the
command is not sent. Preserve the existing token assignment and callback
behavior for successful sends.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: be0e43ad-a7e7-43bb-aff6-8c47a007ae54
📒 Files selected for processing (12)
Core/MultiBotComm.luaLocales/MultiBotAceLocale-deDE.luaLocales/MultiBotAceLocale-enGB.luaLocales/MultiBotAceLocale-enUS.luaLocales/MultiBotAceLocale-esES.luaLocales/MultiBotAceLocale-frFR.luaLocales/MultiBotAceLocale-koKR.luaLocales/MultiBotAceLocale-ruRU.luaLocales/MultiBotAceLocale-zhCN.luaREADME.mdUI/MultiBotFormationUI.luadocs/ROADMAP.md
1 participant
Moves formation selection and inspection out of PARTY/RAID chat, adds a localized per-bot formation tooltip, and keeps the scope raid-wide for all controllable bots.
Summary by CodeRabbit
New Features
Documentation