Skip to content

MultiBot: improve strategy command rejection diagnostics #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wishmaster117 merged 1 commit into from
Aug 7, 2026
Merged

MultiBot: improve strategy command rejection diagnostics #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions Core/MultiBotComm.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,12 @@ end
function Comm.RunStrategyCommand(scope, target, stateScope, changes, callback)
local state = ensureBridgeState()

if not state.connected or not state.strategyMutationCapable then
if not state.connected then
state.lastError = "STRATEGY_NOT_CONNECTED"
return false
end
if not state.strategyMutationCapable then
state.lastError = "STRATEGY_CAPABILITY_UNAVAILABLE"
return false
end

Expand All @@ -690,18 +695,27 @@ function Comm.RunStrategyCommand(scope, target, stateScope, changes, callback)
changes = validateStrategyMutationChanges(changes)

if scope ~= "ALL" and scope ~= "GROUP" and scope ~= "PARTY" and scope ~= "RAID" and scope ~= "BOT" then
state.lastError = "STRATEGY_INVALID_SCOPE"
return false
end
if scope == "BOT" and target == "" then
state.lastError = "STRATEGY_TARGET_REQUIRED"
return false
end
if scope ~= "BOT" and target ~= "" then
state.lastError = "STRATEGY_TARGET_NOT_ALLOWED"
return false
end
if stateScope ~= "C" and stateScope ~= "N" then
state.lastError = "STRATEGY_INVALID_STATE_SCOPE"
return false
end
if not changes then
state.lastError = "STRATEGY_INVALID_CHANGES"
return false
end
if not changes or countTableEntries(state.strategyMutationCommands) >= STRATEGY_MUTATION_MAX_ACTIVE then
if countTableEntries(state.strategyMutationCommands) >= STRATEGY_MUTATION_MAX_ACTIVE then
state.lastError = "STRATEGY_TOO_MANY_REQUESTS"
return false
end

Expand All @@ -725,6 +739,7 @@ function Comm.RunStrategyCommand(scope, target, stateScope, changes, callback)

if not Comm.Send("RUN", payload) then
state.strategyMutationCommands[token] = nil
state.lastError = "STRATEGY_SEND_FAILED"
return false
end

Expand Down
Loading