P2B: Inventory read/refresh strict bridge routing

[Wishmaster117]

Summary by CodeRabbit

• Bug Fixes
  • Improved inventory refresh reliability after item use, equipment changes, looting, and trades.
  • Prevented unsupported or disconnected bridges from issuing inventory requests.
  • Removed unintended fallback behavior that could leave inventory views waiting indefinitely.
  • Inventory screens now clear stale item and summary data when switching between bots.
  • Inventory request failures are now reported correctly instead of appearing successful.
  • Refreshes now accurately reflect bridge availability and supported inventory capabilities.
  • Cleared stale loading states when inventory refreshes cannot be issued.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e263cfa3-97e3-442a-8b0c-84c82909881d

📥 Commits

Reviewing files that changed from the base of the PR and between 94bc138 and e2974ef.

📒 Files selected for processing (1)

• Core/MultiBotEngine.lua

🚧 Files skipped from review as they are similar to previous changes (1)

• Core/MultiBotEngine.lua

---

📝 Walkthrough

Walkthrough

Inventory refreshes now require negotiated bridge capability for bridge requests. Routing records failures and controls legacy fallback. Event handlers and UI paths clear stale wait states and return actual request results.

Changes

Inventory refresh routing

Layer / File(s)	Summary
Bridge capability tracking Core/MultiBotComm.lua	The bridge tracks INVENTORY_V1, enables it from CAPS messages, and clears it on disconnect or world entry. Inventory requests require connection and capability. INV_BEGIN responses now update request state before reaching the UI.
Refresh routing and post-action scheduling Core/MultiBotEngine.lua	Inventory refreshes select bridge or legacy routing, record failures, clear wait states, initialize payload state, and schedule delayed refreshes only for capable bridges.
Event and UI result propagation Core/MultiBotHandler.lua, UI/MultiBotInventoryFrame.lua	Event handlers remove legacy refresh fallbacks. UI requests clear stale inventory state and return actual request results.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant UserInterface
  participant MultiBotEngine
  participant MultiBotComm
  participant RemoteBridge
  UserInterface->>MultiBotEngine: RequestInventoryRefresh
  MultiBotEngine->>MultiBotComm: request inventory when connected and capable
  MultiBotComm->>RemoteBridge: send inventory request
  RemoteBridge-->>MultiBotComm: return INV_BEGIN response
  MultiBotComm-->>MultiBotEngine: return request result
  MultiBotEngine-->>UserInterface: return refresh result

Loading

Possibly related PRs

• Wishmaster117/MultiBot-Chatless#49: Both changes modify bridge capability negotiation in Core/MultiBotComm.lua.
• Wishmaster117/MultiBot-Chatless#54: Both changes add capability-gated bridge requests and capability state tracking in Core/MultiBotComm.lua.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: strict bridge routing for inventory read and refresh operations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch p2b-inventory-read-refresh-strict-bridge

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Wishmaster117]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45dd663b41

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Wishmaster117]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 94bc138856

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Wishmaster117]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: e2974ef4cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".