Conversation
There was a problem hiding this comment.
Pls check out this guide on git commit messages:
https://cbea.ms/git-commit/#seven-rules
It's not a canonical guide, but it basically sums up what I try to accomplish, and I formed that habit from similar guides in the past.
If you're using a GUI utility, the "rename commit" feature probably will help you do what needs to be done. If you're using the command line, I'm not sure the exact commands to change a commit message. If you're using the web UI, I am not sure if it even supports that feature. It might not.
| if(GetInputPressed(this_mo.controller_id, "k")) | ||
| { | ||
| SetOnFire(true); | ||
| } |
There was a problem hiding this comment.
This can also be fixed up by editing your previous commit and doing a force push.
There was a problem hiding this comment.
Only do force pushes in PRs or branches, btw, and not ones that people may be working on. It's generally frowned upon because it requires people to pull your changes before they do anything else in that same branch.
There was a problem hiding this comment.
hello - sorry about the late response, i had my hands really full with the map jam and uni stuff
thank you for your feedback, i'll get around to updating this and my other pr's accordingly over this weekend ideally. might not be able to do all of them but at the very least most of the smaller ones, like this one, i should have done by sunday's end
i also just wanted to take this opportunity to say that i really do mean thank you for the feedback.
deadass when i started this pr jazz i didn't even know what a pointer is or how classes worked lol. only just learnt what virtual functions are like, yesterday. so yeah, genuine apologies about the bugs and other "incompleteness-es" but i really appreciate the time you've taken to point them out and explain them
i'll be sure to put extra care in my future prs
2 participants
There are 12 decimal places. Mayhaps that's too many.