Champs page#68#71
Draft
VincentLeighton wants to merge 13 commits into
Draft
Conversation
Added Champion Display Page
Added routing and navigation to Chamption Display Page
Added component for individual champ to be displayed in champ display page Added interface for ChampDisplay and added IChampDisplay to index
Added API calls to static Dragon page for latest version call and all champion data
Completed champion page, added champ images from static png Updated IChampDisplay and added IChampImage Updated index
Collaborator
Author
|
|
Added API call to dragon for single champ data call
Added interfaces for champ info and updated index
Added routing for ChampDisplay page
Added link to ChampInfo page, added ChampInfo page ChampInfo currently getting champ object but not displaying on page
Update to API return only champ data
IChampInfo cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Progress on the all champs page addition
Screenshot(s) (if applicable, e.g. style updates)
PR Readiness Checklist
main)maininto feature branch (so it has latest code)main