Adds conditional rendering of adhoc registration - #289
Conversation
|
@Sowmiya07 , would it be possible to exclude mentor from the dropdown if he/she has been chosen as another priority? |
|
@Sowmiya07 , while testing I hit this problem of providing memberType: "memberTypes: At least one member type must be provided (e.g., Member, Volunteer, etc.)¨ |
|
@nora-weisser Exclusion of mentor, we can pickup later. I am afraid we don't have enough time now. I tried submitting mentee registration and its working fine for me. I am testing with current main version. Can you please check if the backend code is up-to-date?
|
…oding-Community/wcc-frontend into feat/adhoc-registration
|
I think that "Available hours per month" can be confusing for ad-hoc, as they will commit only 1 hour per month per 1 mentor. They have one-off session. Would be good to give it a thought and see if we can send 3 hrs in the payload, if the mentee applied for 3 mentors in the cycle. What do you think? @Sowmiya07 |
There was a problem hiding this comment.
Approved from my side. I reviewed the main ad-hoc registration changes and they look aligned with what was discussed in the call. The NOSONAR/cognitive complexity refactor and backend-driven available mentors logic can be tracked as follow-up improvements.
I checked the failing CI. The failure seems to be in MenteeRegistrationPage.test.tsx because window.scrollTo is not implemented in jsdom. This looks related to the test environment rather than the production flow, but it would be good to mock/fix it before merging.
dricazenck
left a comment
There was a problem hiding this comment.
Please have a look in failing test, once is fixed I think all good to be merged.
|
|
||
| <Grid item xs={12}> | ||
| <FormControl> | ||
| {!isAdhoc && ( |
|







Description
Summary
Changes
Type
Related Issue
Screenshots
Registration Open and Its Long Term

Correct Available Hours validation

Mentorship Type is not shown
Dual Validation message not shown

Show only cycle relevant mentors



Adhoc
Pull request checklist
Please check if your PR fulfills the following requirements: