-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Remove IE support from Twenty Twenty-One #10857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
…t/wordpress-develop into t21-remove-ie-support
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
westonruter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So good to remove all this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes Internet Explorer support from the Twenty Twenty-One WordPress theme. IE11 reached end-of-life in 2022, making this cleanup appropriate for WordPress core themes.
Changes:
- Removed IE-specific stylesheets and SASS imports from build process
- Deprecated IE class detection function and removed its action hook
- Registered empty polyfill script handles for backward compatibility
- Removed polyfill dependencies from navigation and embed scripts
Reviewed changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
functions.php |
Removed IE stylesheet logic, registered empty polyfill handles, removed polyfill dependencies, deprecated twentytwentyone_add_ie_class() function and removed its action hook |
package.json |
Removed build:ie and build:ie-editor npm scripts |
style.css |
Removed 58 lines of IE-specific CSS targeting .is-IE class |
style-rtl.css |
Removed 58 lines of IE-specific RTL CSS |
style.css.map |
Updated source map to reflect removed IE utilities |
assets/sass/style.scss |
Removed import of 07-utilities/ie |
assets/sass/07-utilities/ie.scss |
Replaced IE styles with comment indicating removal |
assets/js/polyfills.js |
Replaced polyfills with comment indicating removal |
assets/css/ie.css.map |
Replaced with empty map |
assets/css/ie-editor.css |
Replaced with comment indicating removal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "<script>$script</script>\n"; | ||
| } | ||
| } | ||
| add_action( 'wp_footer', 'twentytwentyone_add_ie_class' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the function is still present as the action get removed?
Got it. Leave this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shell we remove this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer not to remove any files, though removing an unused .scss file theoretically should be safe.
is-IEclass.Props: iflairwebtechnologies
Trac 64590
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.