Update/add STET languages - #336
linearcombination wants to merge 10 commits into
Conversation
linearcombination
changed the title
By request of PO
By request of PO
By request of PO
By request of PO
99b4a2b to
296a522
Compare
|
Flipping this to draft overnight while I add a few more tests. Will mark ready for review once they're pushed! |
Ensure new languages are present in non-production environment.
| "pt-br": ("Referência de Origem", "Referência de Destino", "Status", "OK"), | ||
| "rmn-x-yerliroman": ( | ||
| "gu": ( | ||
| "Препратка към изходния текст – текста на български", |
There was a problem hiding this comment.
This looks like a bug -- Romanian text now appears under Gujurati.
There was a problem hiding this comment.
Good catch! git cherry picking went south, oops.
| "f10", | ||
| "nav", | ||
| "reg", | ||
| "tbi", |
There was a problem hiding this comment.
Should bpb and tbi be added to the lists in page.svelte:49 and 99?
There was a problem hiding this comment.
Yes, thanks. I really don't like that regex code in the UI. Will improve that, it is a code smell for sure.
| "nav": "New Arabic Version (Ketab El Hayat)", | ||
| "reg": "Regular", | ||
| "rg": "NT Survey Reviewers' Guide", | ||
| "tbi": "Bahasa Indonesian Bible", |
There was a problem hiding this comment.
I think tbi should have a different description than ayt -- maybe add the code to the label? (e.g. "Bahasa Indonesian bible (tbi)"?)
There was a problem hiding this comment.
Thanks for the nudge. I have updated it. The resource codes get added to the UI presentation in another part of the code already.
After more research using AI in response to code review.
Used several AIs to check each language. Needs native speaker review.
Some languages have more than one USFM resource type. Some of the those languages have a preference for one to be its primary USFM resource. Provide rules to make sure those preferences are respected in the generated document when two USFM resource types are chosen for one language.
Add tbi and bpb USFM resource types to regex. Fix bug in regex. A better solution will come later, but for now this works.
2 participants
Closes #341, closes #342, closes #346, closes #348, closes #350