Smarter book strings for first page of documents - #337
Merged
linearcombination merged 1 commit intoSep 17, 2026
Merged
linearcombination merged 1 commit into
linearcombination merged 1 commit into
Conversation
Only list books when they are a subset not equal to the set of OT, NT, or both, otherwise do 'Old Testament', 'New Testament', and 'Old and New Testament' respectively. It would be nice to localize these three phrases, but currently it doesn't.
Contributor
Author
|
Flipping this to draft overnight while I add a few more tests. Will mark ready for review once they're pushed! |
linearcombination
marked this pull request as draft
September 17, 2026 05:34
PurpleGuitar
approved these changes
Sep 17, 2026
linearcombination
marked this pull request as ready for review
September 17, 2026 22:50
linearcombination
merged commit Sep 17, 2026
d709cb4
into
WycliffeAssociates:doc-dev.walink.org
8 checks passed
github-project-automation
Bot
moved this from In Review
to Done
in DOC Project Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only list books when they are a subset not equal to the set of OT, NT, or both, otherwise do 'Old Testament', 'New Testament', and 'Old and New Testament' respectively. It would be nice to localize these three phrases, but currently it doesn't.