Add option to control line spacing in STET output doc - #355
Draft
linearcombination wants to merge 3 commits into
Draft
linearcombination wants to merge 3 commits into
linearcombination wants to merge 3 commits into
Conversation
Some users want single line spacing, others double
Some users want single line spacing, others double
Contributor
Author
|
Flipping this to draft overnight while I add a few more tests. Will mark ready for review once they're pushed! |
linearcombination
marked this pull request as draft
September 17, 2026 05:34
Make sure the option is present and that its use causes appropriate changes in dependent UI controls.
PurpleGuitar
approved these changes
Sep 18, 2026
| use_increased_line_spacing: bool, | ||
| ) -> Json[str]: | ||
| logger.debug( | ||
| "passed args: lang0_code: %s, lang1_code: %s, email_adress: %s", |
Contributor
There was a problem hiding this comment.
This logging call now has a fourth parameter, but only three arguments to the logging string. Recommend you add: use_increased_line_spacing: %s
| await expect(page.getByRole('main')).toContainText('Increase line spacing to') | ||
| await expect(page.getByRole('main')).toContainText('Generate File') | ||
| await page.getByRole('button', { name: 'Generate File' }).click() | ||
| await expect(page.getByRole('main')).toContainText('Download') |
Contributor
There was a problem hiding this comment.
It looks like this generation could take a while; I recommend you add the timeout: 64_000 you have on other long calls.
| }) | ||
| }) | ||
|
|
||
| test('test line spacing option', async ({ page }) => { |
Contributor
There was a problem hiding this comment.
This test appears to be outside the "Desktop Tests" block -- is that intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users want single line spacing, others double. Closes #353