Release v0.19.1 - xchain-sync - #17
Merged
Merged
Conversation
…oved into src/db/ The code-structure pass moved src/db.js to src/db/index.js and kept path.join(__dirname, 'sql') at both readers, so the sync-owned DDL directory resolved to src/db/sql/, which does not exist, and the container died at boot with ENOENT from verifySyncTables. Both call sites now go through one sqlDir() helper that resolves src/sql/. The existing verifySyncTables unit tests stub fs.readdirSync and never touched the real directory, which is how the gate stayed green. The new test resolves the same directory the boot path reads, asserts it exists on disk with every sync-owned .sql file, and drives verifySyncTables and createTableFromFile with fs left unstubbed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.19.0 cannot boot: the code-structure pass moved src/db.js to src/db/index.js and left the DDL reader resolving src/db/sql/, so the container died at boot with ENOENT from verifySyncTables.
Fixed by ae23ef1, cherry-picked onto the v0.19.0 tag: both call sites go through one sqlDir() helper resolving src/sql/, with a test that reads the real directory off disk.
Patch train v0.19.1, heights unchanged.