Skip to content

Flag remove#25

Merged
jonathanMweiss merged 4 commits intoschnorrfrom
flag-remove
Nov 2, 2025
Merged

Flag remove#25
jonathanMweiss merged 4 commits intoschnorrfrom
flag-remove

Conversation

@jonathanMweiss
Copy link

Flag removal + fixes on scripts to run LKG and DKG on the local machine (helpful when we want to test DKG binary correctness and output).

@jonathanMweiss jonathanMweiss self-assigned this Oct 27, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the tssNetworkSocketPath command-line flag and refactors the TSS network server creation to automatically determine the socket path from the guardian's identity. The changes enable better local testing of DKG (Distributed Key Generation) functionality.

Key Changes:

  • Removed tssNetworkSocketPath flag and parameter passing throughout the codebase
  • Modified NewServer to automatically derive socket path from the TSS messenger's identity
  • Added test infrastructure for running DKG locally with configurable parameters

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
node/cmd/guardiand/node.go Removed tssNetworkSocketPath flag declaration and updated GuardianOptionTSSNetwork call
node/pkg/node/options.go Removed socketPath parameter from GuardianOptionTSSNetwork function
node/pkg/node/node_test.go Updated test to use parameterless GuardianOptionTSSNetwork
node/pkg/tss/comm/runnable.go Added NewServer wrapper that derives socket path and created newServer with explicit path parameter
node/pkg/tss/comm/server_test.go Updated all test calls from NewServer to newServer and added socket path creation test
node/pkg/tss/internal/cmd/dkg/server.go Removed unused gst parameter from createServer function
node/pkg/tss/internal/cmd/lkg/local_key_generation.go Added frost key validation, changed default config path, stored certificate private key, and improved file permissions
node/pkg/tss/internal/cmd/scripts_test.go Refactored test infrastructure to support both LKG and DKG testing with local execution support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jonathanMweiss jonathanMweiss merged commit c82fe7b into schnorr Nov 2, 2025
17 of 27 checks passed
@jonathanMweiss jonathanMweiss deleted the flag-remove branch November 2, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants