Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the tssNetworkSocketPath command-line flag and refactors the TSS network server creation to automatically determine the socket path from the guardian's identity. The changes enable better local testing of DKG (Distributed Key Generation) functionality.
Key Changes:
- Removed
tssNetworkSocketPathflag and parameter passing throughout the codebase - Modified
NewServerto automatically derive socket path from the TSS messenger's identity - Added test infrastructure for running DKG locally with configurable parameters
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| node/cmd/guardiand/node.go | Removed tssNetworkSocketPath flag declaration and updated GuardianOptionTSSNetwork call |
| node/pkg/node/options.go | Removed socketPath parameter from GuardianOptionTSSNetwork function |
| node/pkg/node/node_test.go | Updated test to use parameterless GuardianOptionTSSNetwork |
| node/pkg/tss/comm/runnable.go | Added NewServer wrapper that derives socket path and created newServer with explicit path parameter |
| node/pkg/tss/comm/server_test.go | Updated all test calls from NewServer to newServer and added socket path creation test |
| node/pkg/tss/internal/cmd/dkg/server.go | Removed unused gst parameter from createServer function |
| node/pkg/tss/internal/cmd/lkg/local_key_generation.go | Added frost key validation, changed default config path, stored certificate private key, and improved file permissions |
| node/pkg/tss/internal/cmd/scripts_test.go | Refactored test infrastructure to support both LKG and DKG testing with local execution support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yossigi
reviewed
Oct 27, 2025
yossigi
requested changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flag removal + fixes on scripts to run LKG and DKG on the local machine (helpful when we want to test DKG binary correctness and output).