Require maintainer approval for every change - #9
Closed
tanglearncode wants to merge 1 commit into
Closed
tanglearncode wants to merge 1 commit into
tanglearncode wants to merge 1 commit into
Conversation
main requires a code owner review before a pull request can merge. Make the maintainer the owner of every path, so approval from any other collaborator does not satisfy it.
Contributor
Author
|
Not needed: approvals from any collaborator with write access should count, so no code owners. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainnow requires one approving review from a code owner before a pull request can merge. This file makes @tanglearncode the owner of every path.Without it, the approval requirement would be satisfied by anyone who is later given write access. With it, only the maintainer's approval counts.
Approvals are also dismissed when new commits are pushed, so an approved pull request cannot change afterwards without a fresh approval. Admins can still bypass and merge.
A pull request cannot be approved by its own author, so this one needs an admin bypass to merge.