Independent openXYOS provision process for Windows install - #34
Draft
XYAIStudio wants to merge 4 commits into
Draft
XYAIStudio wants to merge 4 commits into
XYAIStudio wants to merge 4 commits into
Conversation
NSIS now copies the sealed zip plus openxyos-provision.ps1 and waits for that unelevated process. Extract, start, livez, .install-ready, and autostart live in one script instead of FileWrite cmd/goto glue.
makensis on windows-amd64/arm64 rejected ${TrimNewLines} as an unknown
command. Wait for the sentinel with a small CR/LF strip instead, and
write the exit marker without a trailing newline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows Setup no longer FileWrites
extract-openxyos.cmd/start-sidecar.ps1/wait-openxyos.ps1orgoto liveNodeOk. FreeOS shell copy finishes first (exe, shortcuts, uninstaller). Then NSIS copies the sealedopenxyos-runtime.zipplus a checked-in provisioner and launches that independent unelevated process.openxyos-provision.ps1is the same shape as installing openXYOS alone:tar.exeextract into%LOCALAPPDATA%\FreeOS\openxyos(nestedopenxyos\disthandled; no Expand-Archive)start-sidecar.ps1http://127.0.0.1:3780/api/health/livez.install-readyonly when healthyFreeOS-openXYOSSuccess requires runtime on disk and services up and livez. A livez miss is a provision failure (Setup Abort, error 67/68) — not “shell OK, org broken.” Installer strings point at
provision.logstages (extract/start/livez) instead of blaming port 3780 first.Organization still auto-embeds when
.install-readyexists; no primary 「启动边车」 CTA after a successful provision.Target branch
main(this repo’s integration branch; latest includes Fix NSIS installer abort when openXYOS livez is slow #33)Type of change
Test plan
uv run pytest tests/unit/desktop/test_nsis_uninstall.py tests/unit/desktop/test_openxyos_provisioner.py tests/unit/desktop/test_stage_openxyos_runtime.py -qmake all— 3430 passed, 15 skippedInvalid command: ${TrimNewLines}; fixed by stripping CR/LF in NSIS instead)Windows amd64 silent / elevated verify
Retry only openXYOS with the same process Setup launched:
Do not run the provisioner itself as Administrator.
Checklist
CHANGELOG.mddesktop/README.mddocuments the independent provisioner and verify steps