Fix Windows CI spawn test path comparison - #5
Open
XYAIStudio wants to merge 1 commit into
Open
XYAIStudio wants to merge 1 commit into
XYAIStudio wants to merge 1 commit into
Conversation
Compare workspace_dir as Path objects so native Windows backslashes in config_json match the compiled workspace. Co-authored-by: XYAI Labs <haoboy8@gmail.com>
3 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows CI on #4 failed one test:
test_spawn_writes_registry_and_agent_rowcomparedPath.as_posix()(C:/...) against JSON that stores native Windows paths (C:\\...).The agent row was created. The assertion was platform-incorrect.
Fix: parse
config_jsonand comparePath(workspace_dir) == compiled.workspace.Target branch
mainType of change
Test plan