Fix Windows openXYOS install: extract once, real crash logs, no false ready - #54
Draft
XYAIStudio wants to merge 1 commit into
Draft
XYAIStudio wants to merge 1 commit into
XYAIStudio wants to merge 1 commit into
Conversation
…e ready. Stop unpacking the 560MB runtime zip into Program Files copies; extract once into LocalAppData (staging then move), flatten leftover nested openxyos\openxyos, and write .install-ready only when livez is up and start.pid is still alive. Launch Node via cmd /c file redirect so fail-fast stderr is not swallowed. Co-authored-by: XYAI Labs <haoboy8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
联想机上已确认：一次安装把
openxyos-runtime.zip解压三次（Live +$INSTDIR\openxyos-runtime+$INSTDIR\openxyos），安装极慢；Node fail-fast 时start.out.log/start.err.log为空；.install-ready会在后续启动已死时仍被写入。本 PR 做根因修复：
tar -xf只进%LOCALAPPDATA%\FreeOS\openxyos（同卷 staging → move）。$INSTDIR\openxyos/openxyos-runtime只写 README 桩，不再整包解压。成功后仍删除 zip（保留 Remove leftover openxyos-runtime zip and folder after a successful Windows install #43）。cmd /c "node … >start.out.log 2>start.err.log"，PowerShell redirect 吞掉崩溃输出时再抓一次。fail-fast 必须在start.log留下非空原因。.install-ready门闩：仅在 livez 通过 且start.pid仍存活（或等价的本机 Node）时写入。Shell.Application 声称成功但 start.log 已是 fail-fast / 空日志时改走直接启动，失败用中文说明，不写 ready。openxyos\openxyos载荷，避免错误 cwd。Target branch
develop(feature / fix — default)main（按需求针对 main；请勿合并）Type of change
Test plan
python3 -m pytest tests/unit/desktop/test_openxyos_provisioner.py tests/unit/desktop/test_nsis_uninstall.py tests/unit/desktop/test_stage_openxyos_runtime.py --noconftest→ 48 passed, 1 skipped（WindowsCrashSelfTest在 Linux 上 skip）-CrashSelfTest可跑强制崩溃探测make all未在本环境跑通（无uv/ 未装齐 octop 依赖）。请 CI 或本地补跑。Checklist
CHANGELOG.mddesktop/README.md/ NSIS 注释已改为「一次解压 + stub，不是 sealed 全量副本」