fix(org-ui): full-width Organization pages and scrollable bodies - #70
Draft
XYAIStudio wants to merge 3 commits into
Draft
XYAIStudio wants to merge 3 commits into
XYAIStudio wants to merge 3 commits into
Conversation
Remove the centered max-width column on migrated org-ui pages so they match sibling FreeOS Dashboard content width. Pin Organization path tabs below the title and scroll the PageShell body when content is taller than the viewport. Align list/empty/filter chrome closer to the original openXYOS OpenApp pages without changing host APIs. Co-authored-by: XYAI Labs <haoboy8@gmail.com>
Co-authored-by: XYAI Labs <haoboy8@gmail.com>
Task detail no longer splits a comment list from an empty right-hand detail column. Discussion lives in one chat-style panel (thread + composer) beside task metadata, still using host task comments. Co-authored-by: XYAI Labs <haoboy8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Organization submodule pages under
/organization/...were a centered slim column (max-width: 880–1040px) and, withPageShell fill+overflow: hidden, could not be scrolled when content was taller than the viewport.This PR keeps the FreeOS shell (sidebar + Organization path tabs) and makes the page body full-bleed like Chat / Knowledge / Settings, with a scrollable content region.
Follow-up: Organization Tasks discussion is now one embedded conversation pane (not a comment list plus an empty right-hand detail column).
Target branch
develop(feature / fix — default)main(this repo’s default;developis not present)Type of change
What changed
Layout / scroll
dashboard/src/org-ui/layout/orgPage.module.css—width: 100%, no centeredmax-width..pagewrappers compose that shell.PageShellfill(and mobile path-tabs) now wrap children inpage-shell-scroll-body(overflow-y: auto) so tall pages scroll instead of clipping.ORG_PAGE_SHELL(fill+pathTabsPlacement="below-title") so 12 module tabs sit in two rows under the title, matching Personalization.Tasks conversation (this follow-up)
TaskDetailPageno longer uses a 2-column “comments list | sparse status/assignee” split.org-task-conversation): one chat-style panel — scrollable thread (avatars, bubbles, user vscomment_type=ai) + composer with Send. Empty state when there are no comments.GET/POST /api/org-module/tasks/:id/commentsvia the injectedOrgTasksClient. No FreeOS Chat runtime, no iframe.Visual / interaction closer to openXYOS OpenApp
<button>.人机资源,任务管理,治理引擎,反思引擎).Standalone export
[data-testid^="org-ui-"]so the same pages are usable without PageShell.Pages touched
Adapters: workbench, workspace, announcements, org chart, employees (+ detail), skills, governance, knowledge, tasks (+ detail), reflections, settings, agents.
org-ui: shared layout + CSS/pages above.
PageShell(allfillpages, including Knowledge Bases / Personalization).Tasks-specific:
dashboard/src/org-ui/pages/tasks/TaskDetailPage.tsx,TasksPage.module.css,labels.ts,TaskDetailPage.test.tsx.Intentional remaining differences
html-to-image/ jsPDF). Host/api/org-module/orghas no layout/version/import APIs.knowledge_bases(same rows Chat uses), not sidecar notes/files folders./system-settings./api/org-module/taskshas no attachments API (openXYOS TaskDetail lists them)./organization/tasksand/organization/tasks/:id), same as openXYOS/tasksand/tasks/:id.Test plan
make allafter this Tasks follow-up (in progress)Focused Tasks vitest (8 tests) passed after the conversation merge. Browser E2E of Organization routes was not run in this environment (no running FreeOS UI). Closest substitute: unit tests + CSS contract test that
.pageis not a centeredmax-widthcolumn.Checklist
CHANGELOG.md(if user-facing)