Conversation
There was a problem hiding this comment.
Code is more or less ok, but I have a new challenge for you. Please add unit tests (in a separate file) to this program.
Your unittests should document expected responses from API which you are using, Also your tests should tests, whether your program behaves as expected in case of different errors returned by a 3rd party API.
|
bump |
| param = { | ||
| "base": start | ||
| } | ||
| response = requests.get("https://api.exchangeratesapi.io/latest", params=param) |
There was a problem hiding this comment.
this tests should test currency_converter, and not make a request to https://api.exchangeratesapi.io/latest API.
You should try to mock a response of this API, by mocking response of requests.get. Here is an example how you can do that: https://realpython.com/testing-third-party-apis-with-mocks/ (don't bother with nose in this article - an alternative python testrunner)
TL;DR; Your test by mocking a response of requests.get will simulate a server https://api.exchangeratesapi.io/latest.
Pros of this approach:
- This will be an unittest and not an integration test
- it will "freeze" in a test in some kind of documentation a response of an API, which current implementation support.
- such unittests will pass on computer being offline. No internet connection is needed.
- they will be much faster - no latency.
| print("Musisz podać liczbę!") | ||
| continue | ||
| print("Trwa sprawdzanie kursu...") | ||
| currency_converter(start_currency, end_currency, amount_currency) |
There was a problem hiding this comment.
currency_converter returns value, but this value is never used.
…turn only round-converted value
2 participants
No description provided.