Feature kitchen orders#2
Conversation
Bilal-S
left a comment
Bilal-S
left a comment
There was a problem hiding this comment.
@shablenko-sednor
I removed the hotel branding and made some correction when room number is no longer there but we also need to remove the 60s automatic polling and replace the Slack key with a comment & only sent message when there is key.
| </button> | ||
| </td> | ||
| <td class="text-right">${order.roomNumber || ""}</td> | ||
| <td class="text-right">${order.roomNumber == 'undefined' ? '100': order.roomNumber }</td> |
There was a problem hiding this comment.
This is checking whether order.roomNumber is the string "undefined". I don't believe that is what you meant. Maybe you wanted to check whether order.roomNumber is undefined (i.e., not set or was set to undefined).
| <td class="text-right">${order.roomNumber == 'undefined' ? '100': order.roomNumber }</td> | |
| <td class="text-right">${order.roomNumber || "100"}</td> |
In this case, if order.roomNumber is falsy (such as undefined or empty string), then it defaults to "100".
| .map(itemRef => { | ||
| if (/^xb_room_number:/.test(itemRef)) { | ||
| roomNumber = itemRef.split(":")[1]; | ||
| roomNumber = itemRef.split(":")[1]; |
There was a problem hiding this comment.
This removes the whitespace at the end of the line.
| roomNumber = itemRef.split(":")[1]; | |
| roomNumber = itemRef.split(":")[1]; |
|
@Bilal-S @shablenko-sednor I made some suggestions for the recent changes. |
3 participants
Implement kitchen orders page