Render policy and device capabilities for SplatMetalView - #1
Merged
Merged
Conversation
SplatMetalView.renderPolicy and deviceCapabilities, over SKRenderPolicy, SKDeviceCapabilities and -[SKSplatEngine applyRenderPolicy:reason:warnings:]. The shared engine re-validates each request on the render thread; Metal applies the sort depth with GPU sort and the sub-pixel threshold under tight culling, and other fields fall back with a warning. The SPLATKIT_METAL_MIN_PIXEL_RADIUS and SPLATKIT_METAL_DEPTH_KEY_BITS environment variables are removed. Benchmarks log 30-second windows and p99 frame and GPU times, and reject durations outside (0, 3600] seconds. Adds CHANGELOG.md; README, CONTRIBUTING and AGENTS live only at the repository root.
Owner
Author
iPhone runiPhone 17 Pro (A19 Pro), physical device, Release build of
|
Owner
Author
iPhone heavy run: ISSiPhone 17 Pro (A19 Pro), same build as above.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SplatMetalView.renderPolicyanddeviceCapabilities, withSKRenderPolicy,SKDeviceCapabilitiesand-[SKSplatEngine applyRenderPolicy:reason:warnings:].resolveRenderPolicy,SplatEngine::setRenderPolicy) re-validates each request on the render thread.Metal applies the sort depth with GPU sort and the sub-pixel threshold under tight culling; every other field falls back with a warning, and an invalid request keeps the previous policy.
SPLATKIT_METAL_MIN_PIXEL_RADIUSandSPLATKIT_METAL_DEPTH_KEY_BITS; setrenderPolicyinstead.(0, 3600]seconds.CHANGELOG.md; the duplicatepackages/splatkit-ios/distribution/copies of README, CONTRIBUTING and AGENTS are removed, since their links resolve only from the root.Exported from the SplatKit monorepo at
6237bb8withscripts/export-ios-source.py --platform ios.Validation
Before merging
Package.swiftstill pins the0.1.0-alpha.2XCFramework, sorenderPolicystays unreleased until an alpha.3 binary is published.