feat(web): group room devices by category - #442
Open
wei-dou wants to merge 2 commits into
Open
Conversation
|
👋 感谢提交 PR @wei-dou!维护者会尽快 review。 提交前请确认:
|
[PR #442]: feat(web): group room devices by category作者: wei-dou 修改方案要解决的问题:设备总览页此前只按房间平铺展示设备,一个房间几十个设备时列表又长又乱,用户很难在同一房间内快速定位某一类设备(灯、传感器、安防…)。本 PR 从 #360 拆出,只做「房间内按类别聚类 + 排序」,不触碰 statusKind 语义。 整体方案:
测试覆盖:
整体实现干净:类型用 问题🔵 建议(可选优化)
结论LGTM — 实现干净、类型穷举有保障、无重复键、PR 描述与代码逐条对得上,测试覆盖了核心排序/分组契约。仅 3 条 🔵 可选优化(一处无用重排、一处英文文案冗余、一处图标/分组视觉不一致),均不阻塞合并。 由 review-pr skill v1.6 生成 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split from #360 so room device grouping can be reviewed independently from status semantics. This PR intentionally does not depend on the statusKind changes.
Verification
cd web && corepack pnpm buildcd web && NODE_OPTIONS='--no-experimental-webstorage' ./node_modules/.bin/vitest run tests/DevicesByRoom.test.ts