fix(test): isolate tmpdir from parent git worktree in test fixtures#1256
Merged
Conversation
Add outsideGit option to tmpdirScoped and withTmpdirOutsideGit helper to create tmpdirs outside the repo's git worktree, preventing tests from inheriting the parent repo's .git directory. Fix tests that require a non-git environment or explicit git init: - migrate-global.test.ts, project.test.ts: use withTmpdirOutsideGit - worktree.test.ts: pass outsideGit option to provideTmpdirInstance - lsp/index.test.ts: enable git for LSP spawn test - instruction.test.ts: enable git for project tmpdir - classify-integration.test.ts, length-tool-safety.test.ts: fix tool arg casing (filePath -> file_path)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outsideGitoption totmpdirScopedandwithTmpdirOutsideGithelper to create tmpdirs outside the repo's git worktree.gitdirectory, causing false positives/negativesfilePath→file_path) in scripted LLM stub responsesChanges
test/fixture/fixture.tsoutsideGitTmpRoot(),withTmpdirOutsideGit(), andoutsideGitoption totmpdirScoped/provideTmpdirInstancetest/project/migrate-global.test.tswithTmpdirOutsideGitfor non-git project testtest/project/project.test.tswithTmpdirOutsideGitfor non-git directory testtest/project/worktree.test.tsoutsideGit: trueforNotGitErrortesttest/lsp/index.test.tsgit: truefor LSP spawn testtest/session/instruction.test.tsgit: truefor project tmpdirtest/session/classify-integration.test.tstest/session/length-tool-safety.test.ts