fix(test): isolate tmpdir from parent git worktree and tighten directory security#1259
Merged
Merged
Conversation
…ory security - Add `outsideGit` option to shared `tmpdir()` fixture helper - Extract duplicated `withTmpdirOutsideGit` helpers into fixture module - Refactor `assertSafeDirectory` to use prefix-based checks with resolved paths - Fix checkpoint tests to use correct project ID and memory file names - Handle worktree bootstrap failure events in test listener - Restore previous spawnRef in actor-cancel tests via afterAll - Update SDK types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outsideGitoption to sharedtmpdir()fixture helper, eliminating duplicatedwithTmpdirOutsideGitfunctions across test filesassertSafeDirectoryto use prefix-based checks with resolved paths for stronger securityInstance.project.id) and memory file names (MEMORY.md)spawnRefin actor-cancel tests viaafterAllto avoid test pollution