fix(session): reserve output headroom when limit.input is set in isOverflow#1265
Open
0xSkybreaker wants to merge 1 commit into
Open
Conversation
…erflow The usable() function subtracted outputReserve only when using the full context window, but not when limit.input was set. This meant compaction would only trigger after consuming the full input budget, leaving zero room for the next API call output tokens — potentially causing model calls to fail. Fix: consistently subtract outputReserve in both branches of the ternary, so models with limit.input get the same output headroom reservation as models using the full context window. Also updated the previously-skipped "BUG" tests in overflow.test.ts to reflect the corrected behavior and serve as regression tests. Related: #10634, #8089, #11086, #12621
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
usable()function inoverflow.tssubtractedoutputReserveonly when using the full context window, but not whenlimit.inputwas set. This meant compaction would only trigger after consuming the full input budget, leaving zero room for the next API call's output tokens — potentially causing model calls to fail.Root Cause
In
packages/opencode/src/session/overflow.ts, theusable()function had a ternary:The
outputReserve(capped at 20K) was only subtracted in theelsebranch. Models withlimit.inputset (e.g., Claude with prompt caching) got no output headroom, meaning compaction didn't trigger until the full input budget was exhausted — leaving no room for the model to generate a response.Fix
Both branches now consistently reserve output headroom before triggering compaction.
Tests
limit.inputpath symmetric with the context-only path — models with identical real capacity now agree on when to compactRelated: #10634, #8089, #11086, #12621