fix(actor): emit metadata before resolveModelRef to preserve failed subtask state#1273
Open
MiMoHardFather wants to merge 1 commit into
Open
fix(actor): emit metadata before resolveModelRef to preserve failed subtask state#1273MiMoHardFather wants to merge 1 commit into
MiMoHardFather wants to merge 1 commit into
Conversation
…ubtask state When resolveModelRef fails (e.g. unknown model), the tool state was left without sessionId/model metadata, breaking TUI navigation into the failed subtask. Emit metadata early with a parsed fallback model so the error state is always navigable. Also updates tests: MCP lifecycle test for auto-connect behavior, and moves cache_control to tool_use/tool_result blocks in LLM stream test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveModelRefso that when model resolution fails, the failed tool state remains navigable in the TUIcache_controlto tool_use/tool_result blocks in LLM stream testProblem
When
resolveModelReffails (e.g. unknown model referenced), the tool execution short-circuits beforeonReadyfires, leaving the failed subtask tool state without metadata. This breaks TUI navigation into the failed subtask.Fix
Parse the model reference into a fallback model and emit metadata early. If
resolveModelRefsubsequently succeeds, the model is still correct; if it fails, the metadata is already set and the error state is navigable.