fix: handle EEXIST in mkdir for OneDrive-synced .git/info on Windows#1284
Open
0xSkybreaker wants to merge 1 commit into
Open
fix: handle EEXIST in mkdir for OneDrive-synced .git/info on Windows#12840xSkybreaker wants to merge 1 commit into
0xSkybreaker wants to merge 1 commit into
Conversation
On Windows, mkdir with {recursive: true} throws EEXIST when the
target directory has the ReadOnly NTFS attribute (commonly set
by OneDrive on synced folders). This is a known libuv/Node.js
issue (nodejs#43994).
Catch and suppress EEXIST in setupProjectIdEnvironment so MiMo
Code can start in OneDrive-synced Git repositories.
Closes: XiaomiMiMo#721
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
mkdirwith{recursive: true}throwsEEXISTwhen the target directory has the ReadOnly NTFS attribute (commonly set by OneDrive on synced folders). This is a known libuv/Node.js issue (nodejs#43994).Catch and suppress
EEXISTinsetupProjectIdEnvironmentso MiMo Code can start in OneDrive-synced Git repositories.Closes: #721