Skip to content

SWUTILS-968: Highlight SELinux as an interesting value#45

Open
dchadwic-xilinx wants to merge 1 commit into
Xilinx-CNS:mainfrom
dchadwic-xilinx:SWUTILS-968
Open

SWUTILS-968: Highlight SELinux as an interesting value#45
dchadwic-xilinx wants to merge 1 commit into
Xilinx-CNS:mainfrom
dchadwic-xilinx:SWUTILS-968

Conversation

@dchadwic-xilinx

Copy link
Copy Markdown
Collaborator

This is motivated by a couple of occasions where SELinux was enabled but this was not noticed despite it being important to the diagnosis of the issue.
This patch also redesigns the change I made for #27 to the apply_interest_rules sub by supporting the case where the input value is an array.
image
I will note, the "Linux" being used by the context here is undesirable - more on that below.
image

Comment thread sfreport.pl
Comment on lines 844 to 845
my @attributes = ('OS Name', 'Version', 'Architecture');
my @value = ($os_type, "$os_release $os_version", $arch);

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: the "Linux" bit in the Summary of interesting values. I could update the System Summary so that the new values[0] is a chosen word like "Configuration"

Suggested change
my @attributes = ('', 'OS Name', 'Version', 'Architecture');
my @value = ('Configuration', $os_type, "$os_release $os_version", $arch);

Which would give the following result:

Image Image

Which is a little more elegant - but I would have worries for dataminer implications (shouldn't be an issue - but I'd want to spend some time making sure)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't a enforcing means SELinux enabled and showing as disabled kind of contradicting?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is showing : Warning: <section_context> - <condition> (<real_value>)
Basically same as saying condition check <Selinux ne "Disabled"> failed, its actually ("Enforcing")

@ibeecraft-amd ibeecraft-amd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful to grab and the addition of string comparisons to interesting values is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants