SWUTILS-968: Highlight SELinux as an interesting value#45
SWUTILS-968: Highlight SELinux as an interesting value#45dchadwic-xilinx wants to merge 1 commit into
Conversation
| my @attributes = ('OS Name', 'Version', 'Architecture'); | ||
| my @value = ($os_type, "$os_release $os_version", $arch); |
There was a problem hiding this comment.
Re: the "Linux" bit in the Summary of interesting values. I could update the System Summary so that the new values[0] is a chosen word like "Configuration"
| my @attributes = ('', 'OS Name', 'Version', 'Architecture'); | |
| my @value = ('Configuration', $os_type, "$os_release $os_version", $arch); |
Which would give the following result:
Which is a little more elegant - but I would have worries for dataminer implications (shouldn't be an issue - but I'd want to spend some time making sure)
There was a problem hiding this comment.
Isn't a enforcing means SELinux enabled and showing as disabled kind of contradicting?
There was a problem hiding this comment.
This is showing : Warning: <section_context> - <condition> (<real_value>)
Basically same as saying condition check <Selinux ne "Disabled"> failed, its actually ("Enforcing")
ibeecraft-amd
left a comment
There was a problem hiding this comment.
Useful to grab and the addition of string comparisons to interesting values is useful.
This is motivated by a couple of occasions where SELinux was enabled but this was not noticed despite it being important to the diagnosis of the issue.


This patch also redesigns the change I made for #27 to the
apply_interest_rulessub by supporting the case where the input value is an array.I will note, the "Linux" being used by the context here is undesirable - more on that below.