fix: make hintmap label lowercase as all strings are mad lowercase#252
Merged
chvamshi-xilinx merged 1 commit intoXilinx:main-gefrom Mar 26, 2026
Merged
Conversation
Signed-off-by: Himanshu Choudhary <Himanshu.Choudhary@amd.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR normalizes PREEMPT hintmap labels to lowercase during ASM parsing so the internally tracked hintmap keys match the lowercased argument strings used elsewhere in the preprocessor pipeline.
Changes:
- Lowercase the optional PREEMPT hintmap label (
args[3]) after stripping a leading@.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+274
to
+276
| if (!hintmap_label.empty()) { | ||
| std::transform(hintmap_label.begin(), hintmap_label.end(), hintmap_label.begin(), | ||
| [](unsigned char c) { return static_cast<char>(std::tolower(c)); }); |
There was a problem hiding this comment.
This new lowercasing logic relies on std::transform and std::tolower, but this translation unit doesn't explicitly include <algorithm> / <cctype>. It currently compiles only if those headers are pulled in transitively; please add the direct includes to make this file self-contained and portable across toolchains.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
chvamshi-xilinx
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)