Skip to content

limit max section in elf as elfio dont support extended section#253

Open
HimanshuChoudhary-Xilinx wants to merge 1 commit intoXilinx:main-gefrom
HimanshuChoudhary-Xilinx:max_section
Open

limit max section in elf as elfio dont support extended section#253
HimanshuChoudhary-Xilinx wants to merge 1 commit intoXilinx:main-gefrom
HimanshuChoudhary-Xilinx:max_section

Conversation

@HimanshuChoudhary-Xilinx
Copy link
Collaborator

Problem solved by the commit

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

How problem was solved, alternative solutions (if any) and why they were rejected

Risks (if any) associated the changes in the commit

What has been tested and how, request additional testing if necessary

Documentation impact (if any)

Copilot AI review requested due to automatic review settings March 26, 2026 09:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent generating ELF files that require extended section numbering by enforcing an upper bound on the number of emitted ELF sections (and a derived upper bound on “pages” for AIE2PS ctrlcode generation).

Changes:

  • Added a hard cap on the number of ELF sections created by elf_writer via a new add_section_by_name() helper.
  • Added a derived “max pages” limit in aie2ps_preprocessor and tracked total pages across columns.
  • Switched page index tracking to uint32_t in the AIE2PS preprocessor loop.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/cpp/preprocessor/aie2ps/aie2ps_preprocessor.h Adds a global page-count limit and throws when exceeded; updates page index type.
src/cpp/elf/elfwriter.h Introduces max_sections, a section counter, and a wrapper for adding sections with an enforced cap.
src/cpp/elf/elfwriter.cpp Routes all section creation through the new capped helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Signed-off-by: Himanshu Choudhary <Himanshu.Choudhary@amd.com>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants