limit max section in elf as elfio dont support extended section#253
Open
HimanshuChoudhary-Xilinx wants to merge 1 commit intoXilinx:main-gefrom
Open
limit max section in elf as elfio dont support extended section#253HimanshuChoudhary-Xilinx wants to merge 1 commit intoXilinx:main-gefrom
HimanshuChoudhary-Xilinx wants to merge 1 commit intoXilinx:main-gefrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent generating ELF files that require extended section numbering by enforcing an upper bound on the number of emitted ELF sections (and a derived upper bound on “pages” for AIE2PS ctrlcode generation).
Changes:
- Added a hard cap on the number of ELF sections created by
elf_writervia a newadd_section_by_name()helper. - Added a derived “max pages” limit in
aie2ps_preprocessorand tracked total pages across columns. - Switched page index tracking to
uint32_tin the AIE2PS preprocessor loop.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/cpp/preprocessor/aie2ps/aie2ps_preprocessor.h |
Adds a global page-count limit and throws when exceeded; updates page index type. |
src/cpp/elf/elfwriter.h |
Introduces max_sections, a section counter, and a wrapper for adding sections with an enforced cap. |
src/cpp/elf/elfwriter.cpp |
Routes all section creation through the new capped helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Himanshu Choudhary <Himanshu.Choudhary@amd.com>
ef9293a to
512434e
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)