fix(timer): guarantee no dial/endet overlap and centre text in landscape#26
Merged
Conversation
Replace the scalar translationY shift with a layout-derived slot whose height equals the rotated text's axis-aligned bounding box, driven from the same animatedAngle that rotates the text. The dial size is now constrained by the available height minus this slot, so the dial shrinks when space is tight instead of letting the rotated text bleed back into it. In landscape, apply a layout offset that places the slot's centre at the midpoint between dial bottom and the button row, eased in with the rotation via |sin θ|, so the endet text no longer hugs the dial. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
animatedAnglethat rotates the text — overlap is structurally impossible at every frame, including during the transition and for long localised time strings on tablets.|sin θ|) shifts the slot centre to the midpoint between dial bottom and the button row, so the text reads as equidistant from dial and buttons instead of hugging the dial.Test plan
🤖 Generated with Claude Code