fix(graph): redact runtime error events - #104
Conversation
|
Warning Review limit reached
Next review available in: 17 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
62643ed to
d1662df
Compare
b2770ff to
cca7b08
Compare
* platform: add multi-tenant contracts * platform/gateway: add text loop * platform/toolpolicy: add governance bridge * platform/channeladapter: add adapter outbox skeleton * platform/gateway: enqueue outbound handoff * platform/storagerouter: add storage routing contracts * platform/gateway: add session lease * platform: add gray routing helpers * platform: add tenant budget helpers * platform: validate storage migration modes * platform: validate audit policies * platform: validate audit records * platform: add capacity estimator * platform/channeladapter: replay dead letters * platform: populate audit record ids * platform: validate audit sink writes * platform: add usage record contracts * platform: add usage sink contracts * platform: add config version contracts * platform: select config version by session gray bucket * platform: add config version lifecycle helpers * platform: add usage summary contracts * platform: add audit query contracts * platform: add config version diff contracts * platform: add config gray status summary * platform: add operational action audit contracts * platform: add config cache invalidation contracts * platform: add secret rotation status contracts * platform: add backend migration status contracts * platform: add storage router status summary * platform: add config operation summary contracts * platform/toolpolicy: add approval summary contract * fix(platform): enforce binding ACL and redact outbox errors * fix(platform): redact gateway audit error reasons * fix(toolpolicy): enforce auditable policy identity * platform: harden identity and idempotency contracts * platform: tighten routing identity contracts * fix(platform): reconcile hardened contracts with gateway * platform: add budget decision audit contracts * platform/gateway: add minimum loop acceptance test * platform/gateway: add outbound dispatch acceptance test * platform/gateway: correlate audit trace ids * platform/gateway: add trace skeleton spans * platform/gateway: enable runner session trace * platform/gateway: add message event trace contract * feat(platform): mark tool call trace spans Adds safe platform tool-call trace contract spans. Independent re-review reported P0/P1 clear; CodeRabbit only reported a trivial test-helper nitpick. * feat(platform): trace memory search spans Adds safe memory search trace spans on the current memory.Reader boundary. Independent review reported P0/P1 clear; local focused validation and build passed. * feat(platform): trace memory write spans Adds safe memory write trace spans for add/update/delete/clear. Independent review reported P0/P1 clear; local focused validation and build passed. * feat(platform): mark summary create trace spans Adds summary-create trace contract markers for Redis/PostgreSQL summary creation spans. Independent review reported P0/P1 clear; local focused validation and build passed. * fix(platform): address CI checks * fix(platform): address CodeRabbit review feedback * fix(platform): bound in-memory sink records --------- Co-authored-by: xnlemon <xianingawa@gmail.com>
cca7b08 to
c81e17e
Compare
Objective
Close the next Phase2 runtime redaction gap by preventing graph/runtime model-visible error surfaces from exposing raw provider, node, tool, or Pregel error details.
Completed Changes
model.ResponseError.model.Responsewhile preserving the original response for internal callbacks/state.ResponseError.Message,Code, andParamfields for graph/runtime model-visible response errors.Validation
go test ./graph -count=1 -run 'TestNewExecutionError_NilCallbackContext|TestExecutionErrorCollector_CustomResponseError|TestGraphErrorEventsRedactSensitiveMessages|TestNewToolAndModelEvents|TestNewPregelAndChannelStateEvents|TestEmitExecutionError|TestProcessModelResponse_EventAndErrors|TestEmitFastModelResponseEvent'go vet ./graphgit diff --check0 High / 0 Medium / 0 Lowafter fixes.Known Risks / Limitations
go test ./graphstill has pre-existing timing/retry failures unrelated to this redaction diff, as noted during review.event.NewErrorEventremains unchanged globally; this increment redacts graph/runtime callers only.Follow-up Work