Skip to content

fix(approval): redact reviewer decision text - #82

Open
XnLemon wants to merge 104 commits into
mainfrom
codex/phase2-approval-redaction-audit
Open

fix(approval): redact reviewer decision text#82
XnLemon wants to merge 104 commits into
mainfrom
codex/phase2-approval-redaction-audit

Conversation

@XnLemon

@XnLemon XnLemon commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Objective

Close a Phase2 sensitive-output gap by ensuring approval reviewer text is redacted before it reaches logs or user-visible denial results.

Changes

  • Sanitized approval reviewer RiskLevel and Reason through the platform redactor before approve logging.
  • Reused the sanitized decision text for deny logging and deny PermissionResult reasons.
  • Kept approval audit records on stable fixed decision reasons so reviewer text is not written into audit decision fields.
  • Added regression coverage for token, api_key, Authorization, and password leakage in approve logs, deny logs, and deny results.

Validation

  • go test ./plugin/guardrail/approval ./platform
  • go vet ./plugin/guardrail/approval ./platform
  • git diff --check
  • open-code-review subagent/manual review: 0 High / 0 Medium / 0 Low

Risks / Follow-up

  • This increment only sanitizes reviewer-provided approval text at the approval boundary; remaining Phase2 closure items will continue in follow-up fork-only PRs.

XnLemon added 30 commits July 8, 2026 11:47
@XnLemon
XnLemon force-pushed the codex/phase2-gateway-idempotency-metrics branch from 6c1d201 to 359a9f4 Compare July 11, 2026 13:38
@XnLemon
XnLemon force-pushed the codex/phase2-approval-redaction-audit branch from 2078eb6 to a8819d3 Compare July 11, 2026 13:38
@XnLemon
XnLemon changed the base branch from codex/phase2-gateway-idempotency-metrics to main July 13, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants