[Admin] Add scoped resource discovery with TDesign tables - #117
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
XnLemon
commented
Sep 2, 2026
XnLemon
commented
Sep 2, 2026
XnLemon
left a comment
Owner
Author
There was a problem hiding this comment.
The inline reply documents the scoped tenant-discovery fix and its regression coverage. Submitting this existing draft closes the older review so a fresh clean review can target the latest head.
XnLemon
commented
Sep 2, 2026
XnLemon
commented
Sep 2, 2026
XnLemon
commented
Sep 2, 2026
XnLemon
commented
Sep 4, 2026
XnLemon
commented
Sep 4, 2026
Owner
Author
|
lets go LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Issue #112 as a staged TDesign Admin control-plane experience.
This PR now includes:
/adminmounting support, including Vite asset paths, development SPA fallback, and deep-link routing..smokeartifacts removed from Git tracking and ignored for future local smoke-test output.Issue Ledger
/meprincipal context for the Admin shell./adminproduction mount and development deep-link behavior.The unchecked items are independent follow-up capabilities and remain documented in
docs/docs/admin-web-ui.md.Validation
go test ./... -count=1go test -race ./trpcservice/admin ./trpcservice/gateway ./trpcservice/bootstrapnpm testfromadmin-uinpm run buildfromadmin-uinpx tsc --noEmitfromadmin-uigit diff --checkReview Fixes Included
503 storage_unavailableresponse.GlobalInstruction.TRPC_ADMIN_TENANTS=*is explicit while empty and explicit scopes remain isolated.Latest Follow-up
List,ListRevisions, andscanRevisionNumbers: receiver/storage guards, page bounds, valid and invalid cursors, filters, empty pages, query/scan/iteration/load failures, UTC normalization, and row-close errors.List,ListRevisions, andscanRevisionNumberseach reach 100% statement coverage in the PostgreSQL package.go test ./trpcservice/agent/... -count=1go test -race ./trpcservice/agent/postgres -count=1context.Canceledbefore checking storage, matching the repository cancellation contract.checkList, preserving canceled-context precedence while keeping the list handler below the repository gocyclo threshold.Drawerdeclaration and export used by the Admin shell and resource drawers.npx tsc --noEmit --pretty false,npm test, andnpm run buildpass fromadmin-ui.c528eab6e30ff746dd8fb290a94e174d572639f9has all GitHub checks passing; the review finding for this head is resolved.