fix(launcher): mute notify file-watcher TRACE flood#487
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request configures the logger in asyar-launcher/src-tauri/src/lib.rs to silence verbose trace logs from the notify and notify_debouncer_full crates to prevent log flooding. The reviewer noted that notify-debouncer-full is not used in the project, making its log-level configuration redundant and potentially misleading, and suggested removing it.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Owner
|
Thanks you 🙏. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging the CPU issue, I struggled with asyar.log; 100s of notify::fsevent TRACE lines a second, with nothing helpful saved due to 40kb rotation.
The log plugin doesn't set a global level, so dependencies log at TRACE even in release builds.
This adds notify and notify-debouncer-full to the existing axum/hyper/tungstenite mutes. Warn and above still pass, and fs_watcher/file-index logging is unaffected. Not touching the global level or rotation strategy, just trying to targettedly clean.
Test: