Skip to content

fix(launcher): mute notify file-watcher TRACE flood#487

Merged
Xoshbin merged 1 commit into
Xoshbin:mainfrom
AllDaGearNoIdea:fix/fsevent-log-flood
Jul 10, 2026
Merged

fix(launcher): mute notify file-watcher TRACE flood#487
Xoshbin merged 1 commit into
Xoshbin:mainfrom
AllDaGearNoIdea:fix/fsevent-log-flood

Conversation

@AllDaGearNoIdea

Copy link
Copy Markdown
Contributor

While debugging the CPU issue, I struggled with asyar.log; 100s of notify::fsevent TRACE lines a second, with nothing helpful saved due to 40kb rotation.

The log plugin doesn't set a global level, so dependencies log at TRACE even in release builds.

This adds notify and notify-debouncer-full to the existing axum/hyper/tungstenite mutes. Warn and above still pass, and fs_watcher/file-index logging is unaffected. Not touching the global level or rotation strategy, just trying to targettedly clean.

Test:

  • Run the app, save some files under a watched root, confirm asyar.log no longer fills with notify::fsevent lines
  • Confirm asyar's own log lines still appear
  • cargo test and the notifications suite green

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures the logger in asyar-launcher/src-tauri/src/lib.rs to silence verbose trace logs from the notify and notify_debouncer_full crates to prevent log flooding. The reviewer noted that notify-debouncer-full is not used in the project, making its log-level configuration redundant and potentially misleading, and suggested removing it.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread asyar-launcher/src-tauri/src/lib.rs
@Xoshbin Xoshbin merged commit eaec5e2 into Xoshbin:main Jul 10, 2026
1 check passed
@Xoshbin

Xoshbin commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Thanks you 🙏.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants