Manual graph apply backend split#8
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55efe71e07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| survivor = await self._load_canonical_event_for_merge( | ||
| survivor_canonical_event_id, | ||
| target_id=target_id, | ||
| ) |
There was a problem hiding this comment.
Reject merges into retired canonical events
If survivor_canonical_event_id points to an event already marked status == "merged", this path still accepts it as the survivor and _apply_canonical_merge_plan later moves the candidate mentions onto that retired node while leaving its merged_into metadata intact. In the scenario where A was already merged into B, a subsequent manual merge of C into A will strand C's mentions under A instead of the active survivor B; add a survivor-specific status/merged_into check before building the merge plan.
Useful? React with 👍 / 👎.
Summary
Split boundary
Verification
Note: the full pytest run passed with existing Starlette/httpx deprecation and aiosqlite event-loop warnings.