Fix bugs found in codebase review and add test suite#9
Open
dream-hun wants to merge 7 commits into
Open
Conversation
dream-hun
commented
May 12, 2026
dream-hun
commented
Contributor
- Fix Response code cast: attr() returns string but getCode() declares int; cast to (int) and compare with 1000
- Fix ProvidesCheckCommand: 'domainname' property does not exist on Domain model, use 'name'; remove duplicate setAttributeNodeNS call
- Fix TransferResponse: assign .text() to $token instead of Crawler object; getter return types changed to ?string
- Fix SIDN namespace URLs: http:// → https:// in CreateCommand and LoginCommand service extensions
- Add legalForm mapping in Contact CreateCommand: PERSON → PERSOON, OTHER → ANDERS
- Fix HasExtensions::getExtensions() to actually return $this->extensions
- Fix nullable getter return types in Contact/Host CreateResponse subclasses
- Fix Response code cast: attr() returns string but getCode() declares int; cast to (int) and compare with 1000 - Fix ProvidesCheckCommand: 'domainname' property does not exist on Domain model, use 'name'; remove duplicate setAttributeNodeNS call - Fix TransferResponse: assign .text() to $token instead of Crawler object; getter return types changed to ?string - Fix SIDN namespace URLs: http:// → https:// in CreateCommand and LoginCommand service extensions - Add legalForm mapping in Contact CreateCommand: PERSON → PERSOON, OTHER → ANDERS - Fix HasExtensions::getExtensions() to actually return $this->extensions - Fix nullable getter return types in Contact/Host CreateResponse subclasses
These files are local development aids and should not be tracked in git. Added both to .gitignore so they remain on disk but are never pushed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.