Cert/profile b e2e - #8
Open
Yasou13 wants to merge 2 commits into
Open
Conversation
…igh-throughput batch publishing
There was a problem hiding this comment.
🟡 Changes recommended
Newly introduced polling parameters should validate/clamp negative values to avoid surprising tight-loop polling behavior against the remote API.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adjusts MESA publish-delivery execution behavior to be more resilient in slower end-to-end scenarios by making inline mutation polling configurable and increasing the default HTTP client timeout.
Changes:
- Added
max_inline_pollsandpoll_interval_secondsparameters toexecute_publish_delivery()to control inline mutation polling behavior. - Replaced hard-coded inline polling constants (5 polls, 0.5s sleep) with the new parameters.
- Increased
MesaClientdefaulttimeout_secondsfrom 15s to 60s.
File summaries
| File | Description |
|---|---|
src/mesa_legal_data/publisher/engine.py |
Makes inline mutation polling configurable during publish deliveries. |
src/mesa_legal_data/publisher/client.py |
Increases default HTTP timeout to better accommodate slower MESA responses. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+347
to
+348
| max_inline_polls: int = 5, | ||
| poll_interval_seconds: float = 0.5, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.