fix: full-pass punch list + prettier format#9
Merged
Conversation
Applies prettier formatting to 7 files flagged by CI's `prettier --check src/` step. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Drifted since v0.9.15/0.9.16 bumps skipped release.sh, leaving consumers who install via `rev: vX.Y.Z` executing @0.9.14 through the pre-commit framework. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- mcp-env: skip unset-variable for Continue (its ${{ secrets.X }} refs
resolve from GitHub Actions secrets, not process.env, so every correct
Continue config false-positived)
- ci-secrets: tighten contextMentionsSecret regex -- require a separator
for `_` and anchor with \b, so `NPM_TOKEN` no longer matches bare prose
like `npmtoken` anywhere in a file
- mcph-gitignore: drop the inert `fix` action (oldText: '', line: 0 was
silently skipped by the fixer's bounds check; suggestion stays)
- config: add mcph/mcphOnly/mcphGlobal/mcphStrictEnvToken/session/
sessionOnly/mcpOnly to CtxlintConfig + KNOWN_CONFIG_KEYS; route
--config <path> through shared parser so it reports JSON line/col and
warns on unknown keys
- cli: fold config-sourced booleans into the local flag vars so
effectiveMcp/Mcph/Session and the ignore filter stay consistent when
only a config enables a domain
- git: track current commit header while scanning findRenames so
multi-rename commits attribute the right hash; drop unused
getCommitsSince (superseded by getCommitsSinceBatch)
- session/diverged-file, session/duplicate-memory: switch to Jaccard
(|A n B| / |A u B|) to match the redundancy check; the prior
matches/max(|A|,|B|) was asymmetric (array vs. set on the two sides)
- session/duplicate-memory: scope pairs to those touching the current
project so `ctxlint --session` doesn't echo unrelated cross-project
duplicates every run
- mcph-parser: delegate checkGitignored to `git check-ignore` so the
full gitignore grammar (globs, negation, ancestor files) is honored
- fixer: remove the misleading descending line sort (we mutate lines in
place, so fix order across lines can't shift indices)
- reporter/fixer/loop-detection: swap user-facing Unicode icons
(checkmark/cross/warning/info/arrow/box-draw) for ASCII so Windows
ConPTY doesn't render mojibake
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
jeffyaw
changed the title
Prior fix commit introduced formatting drift the CI prettier check caught. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/full-passreview punch list:mcp-envContinue false-positive,ci-secretsregex tightening,mcph-gitignoreinert-fix removalCtxlintConfiggainsmcph*/session*/mcpOnlykeys;--configroutes through the shared parser for JSON line/col + unknown-key warningsfindRenamestracks commit header while scanning (fixes multi-rename hash attribution); deadgetCommitsSincedeleteddiverged-file/duplicate-memoryswitched to Jaccard;duplicate-memoryscoped to pairs touching the current projectmcph-parser.checkGitignoreddelegates togit check-ignorefixer.tsdescending-line sort removed (mutates in place, order doesn't shift indices).pre-commit-hooks.yamlpin resynced to 0.9.17 (had drifted since the v0.9.15/v0.9.16 bumps)Test plan