Skip to content

Update developer tools and code organisation#34

Merged
YeeShin504 merged 7 commits into
mainfrom
chore/update-dev-env
May 12, 2026
Merged

Update developer tools and code organisation#34
YeeShin504 merged 7 commits into
mainfrom
chore/update-dev-env

Conversation

@YeeShin504
Copy link
Copy Markdown
Owner

Summary

This PR adds pre-commit hooks and moves the expensive orthogonal-completion step used by Matrix.singular_value_decomposition() into a separate worker module.

Highlights

  • Added pre-commit usage guidance so contributors can run the same checks locally before committing.
  • Updated contributor guidance in README.md and `CONTRIBUTING.
  • Added a subprocess worker into src/ma1522/_workers.py so the orthogonal-completion step can run independently and terminated when timeout is raised.
  • Added private method _get_orth(...) to that uses numerical QR fallback when symbolic Gram-Schmidt takes too long.
  • Updated Matrix.singular_value_decomposition() to call the helper and expose a timeout_seconds parameter with a default of 30 seconds.

@YeeShin504 YeeShin504 self-assigned this May 12, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 12, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 90.83333% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ma1522/symbolic.py 84.05% 7 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

@YeeShin504 YeeShin504 merged commit ac4d8bf into main May 12, 2026
15 checks passed
@YeeShin504 YeeShin504 deleted the chore/update-dev-env branch May 12, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants