Update developer tools and code organisation#34
Merged
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds pre-commit hooks and moves the expensive orthogonal-completion step used by
Matrix.singular_value_decomposition()into a separate worker module.Highlights
README.mdand `CONTRIBUTING.src/ma1522/_workers.pyso the orthogonal-completion step can run independently and terminated when timeout is raised._get_orth(...)to that uses numerical QR fallback when symbolic Gram-Schmidt takes too long.Matrix.singular_value_decomposition()to call the helper and expose atimeout_secondsparameter with a default of 30 seconds.