Improve Tron restart times by adding parallelization to job_collection.restore_state() - #1111
Draft
CharlesPeacock wants to merge 1 commit into
Draft
Improve Tron restart times by adding parallelization to job_collection.restore_state()#1111CharlesPeacock wants to merge 1 commit into
CharlesPeacock wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the series of Tron restart improvements.
As of recently, Tron has been seeing restart times of over 6 minutes in pnw-prod. Optimizing these restart times allows for less downtime and more opportunities to experiment with new changes.
This change adds a
ThreadPoolExecutorto parallelizejob_collection.restore_state(). By settingmax_workersto 5 we can see a significant improvement in state restoration times:Original performance (tested with copy of tron-pnw-devc dynamodb table):
Performance after parallelization (same environment as original test, 5 workers):
Tests passed