Add vendor control type configuration#94
Add vendor control type configuration#94CarvalhoJeo wants to merge 5 commits intoYet-Another-Software-Suite:masterfrom
Conversation
thenetworkgrinch
left a comment
thenetworkgrinch
left a comment
There was a problem hiding this comment.
There may be a few more changes regarding BasicOptions in the SMCConfig
Do you consider this to be a basic option of the motor controller? |
|
Unfortunately yes. The basic option enum is to garuntee that the field is always handled everytime a |
|
Sorry for delaying this! Its going to conflict with the LQR branch when i merge it and i am debating how to handle it! |
|
This is probably going to need redone if you dont deal with the merge conflicts. I am so sorry in advance! |
|
NP! Do you have any estimate of when you will merge the LQR branch? Can I try to merge this with the LQR branch and resolve the conflicts earlier? |
|
I need 1 more review of it (i would even accept it if you reviewed it); then we will have a beta period over the weekend and through next week |
|
#97 is the PR |
2 participants
Add new capability to use vendor ControlRequest for Talonfx and ControlType for Spark for either velocity or position.