Repository navigation
[codex] Rename Rails test server to Rack - #47
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #46
Summary
Smartest::Rails::TestServer/smartest/railstoSmartest::Rack::TestServer/smartest/rack.websocket-driveris required only for remote Playwright server connections viaPLAYWRIGHT_WS_ENDPOINT/Playwright.connect_to_browser_server, not local browser runs.Why
The server implementation wraps
Puma::Serveraround the suppliedapp:object, so the public name should describe Rack behavior instead of implying Rails-only behavior. Because the project has no users yet, this PR makes the breaking rename directly instead of adding a compatibility alias.Validation
RBENV_VERSION=3.3.0 rbenv exec bundle exec rake testnpm run buildfromdocumentation/