Skip to content

[codex] Rename Rails test server to Rack - #47

Merged
YusukeIwaki merged 1 commit into
mainfrom
codex/rack-test-server
Jun 3, 2026
Merged

YusukeIwaki merged 1 commit into
mainfrom
codex/rack-test-server

Conversation

@YusukeIwaki

@YusukeIwaki YusukeIwaki commented Jun 3, 2026 •

Copy link
Copy Markdown
Owner

resolves #46

Summary

  • Rename the explicit test server helper from Smartest::Rails::TestServer / smartest/rails to Smartest::Rack::TestServer / smartest/rack.
  • Update the Rails init scaffold, tests, README, and Docusaurus docs to use the Rack naming and document that the server accepts any Rack app.
  • Document that websocket-driver is required only for remote Playwright server connections via PLAYWRIGHT_WS_ENDPOINT / Playwright.connect_to_browser_server, not local browser runs.

Why

The server implementation wraps Puma::Server around the supplied app: object, so the public name should describe Rack behavior instead of implying Rails-only behavior. Because the project has no users yet, this PR makes the breaking rename directly instead of adding a compatibility alias.

Validation

  • RBENV_VERSION=3.3.0 rbenv exec bundle exec rake test
  • npm run build from documentation/

@vercel

vercel Bot commented Jun 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
smartest Ready Ready Preview, Comment Jun 3, 2026 4:24pm

@YusukeIwaki
YusukeIwaki marked this pull request as ready for review June 3, 2026 16:27
@YusukeIwaki
YusukeIwaki merged commit 02f0b3b into main Jun 3, 2026
9 checks passed
@YusukeIwaki
YusukeIwaki deleted the codex/rack-test-server branch June 3, 2026 17:03

This branch was successfully deployed

1 active deployment
Preview — 778a8db0 Deployed Jun 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: gaps discovered while integrating Smartest into a Sinatra (non-Rails) app

1 participant