Pensar - auto fix for Unbounded Tweet Retrieval Resource Exhaustion#25
Open
pensarappdev[bot] wants to merge 1 commit into
Open
Pensar - auto fix for Unbounded Tweet Retrieval Resource Exhaustion#25pensarappdev[bot] wants to merge 1 commit into
pensarappdev[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAX_TWEET_LIMIT = 3200within theUtilsclass to denote the upper bound for tweet fetching.user_lookup_tweepyanduser_lookup_snsmethods:quantityis not a positive integer, raiseValueError.quantityexceedsMAX_TWEET_LIMIT, issue a warning via logger and capquantitytoMAX_TWEET_LIMIT.user_lookup_sns, changed the pagination break condition fromif idx > quantity:toif idx >= quantity:to properly fetch up toquantitytweets.More Details
quantityparameter originates from external input and is passed directly totweepy.Cursor(...).items(quantity)without any upper bound or sanity check. An attacker can request an extremely large number (e.g., 100 million), forcing the application to iterate over a massive number of API calls and objects, potentially exhausting network bandwidth, CPU, memory, and hitting Twitter rate-limits. This constitutes Uncontrolled Resource Consumption (CWE-400) and can be abused for denial-of-service or unexpected cost spikes.