Pensar - auto fix for Unbounded Twitter API Request Resource Consumption#9
Open
pensarappdev[bot] wants to merge 1 commit into
Open
Pensar - auto fix for Unbounded Twitter API Request Resource Consumption#9pensarappdev[bot] wants to merge 1 commit into
pensarappdev[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Issue Fixed:
Utils.user_lookup_tweepy:quantityparameter was previously user-controlled and unchecked, allowing a malicious/naïve caller to request an excessively high number of tweets, resulting in potential Denial of Service through network, memory, or API rate exhaustion.MAX_TWEETS = 3200to cap the maximum retrievable tweets.quantityis not a positive integer, aValueErroris raised.quantityexceedsMAX_TWEETS, it is capped and a log info message is emitted..items(quantity), ensuring no excessive resource usage can occur.There were no dependency issues reported, so no dependency changes were needed.
More Details
quantityargument—fully controlled by external input—is passed unchecked totweepy.Cursor(...).items(quantity). If an attacker supplies an extremely large value, the code will initiate an unbounded number of API requests and store every returned tweet in memory. This leads to excessive network usage, possible Twitter-rate-limit bans, and unbounded memory/CPU growth on the host, resulting in a denial-of-service condition. No upper limit, validation, or throttling is applied.