fix: upgrade whisper-rs to 0.16.0 and fix Windows build#460
Open
TheChiragKaushik wants to merge 1 commit into
Open
fix: upgrade whisper-rs to 0.16.0 and fix Windows build#460TheChiragKaushik wants to merge 1 commit into
TheChiragKaushik wants to merge 1 commit into
Conversation
medeng-dev
reviewed
May 13, 2026
medeng-dev
left a comment
There was a problem hiding this comment.
Build succeeds on Windows 11 with VS 2022 Build Tools (CPU-only mode). App launches correctly. Haven't fully tested transcription and summary functionality yet, but the compilation error with whisper-rs 0.13.2 is resolved.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Windows build which was completely broken due to a
whisper-rs-sys struct layout change. The underlying whisper.cpp C library
restructured its internal structs, making whisper-rs 0.13.2 incompatible
with the latest whisper-rs-sys bindings on Windows.
Changes made:
vulkanfeature from Windows dependencies (VulkanSDK is not installed by default on Windows and was causing build failures
for most users it remains available as an opt-in feature flag via
--features vulkan)set_suppress_non_speech_tokens()→set_suppress_nst()full_get_segment_text_lossy()→get_segment()returning Optionfull_get_segment_t0/t1()→get_segment().start/end_timestamp()?operator fromfull_n_segments()which returns i32WhisperContext::new_with_paramspath deref (&*instead of&)summary/summary_engine/mod.rs to use direct module paths instead of
cmd variants which are incompatible with Tauri 2.11
Related Issue
[Link to the issue this PR addresses (e.g., "Fixes #123")]
Type of Change
Testing
Checklist
Additional Notes
This was tested on Windows 11 with VS 2022 Build Tools. The build requires
VS 2022 Build Tools with "Desktop development with C++" workload due to
ort-sys (ONNX Runtime) requiring newer MSVC runtime symbols not present
in VS 2019.