feature(update): Version 1.0.1, Smoother progress, better cancellation flow#322
Open
theypsilon wants to merge 4 commits into
Open
feature(update): Version 1.0.1, Smoother progress, better cancellation flow#322theypsilon wants to merge 4 commits into
theypsilon wants to merge 4 commits into
Conversation
… are suppressed, but larger drops (10%) will pass through, which gives the UI a way out of stale 100% states.
📝 WalkthroughWalkthroughThis change updates the optional ChangesDependency Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
Mmm, the text from the PR disappeared, Adding it back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Screenshots / recordings
Test plan
Go to the Update option from the main screen. To test the cancel flow, try to interrupt the update.
Checklist
just lintis green (zero warnings)just testpassesdocs/architecture.md)qsTr()(QML) ortr()(C++)Summary by CodeRabbit